Cherry pick from https://github.com/phetsims/friction/issues/314

phetsims / ratio-and-proportion

"Ratio and Proportion" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 4 forks source link

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

zepumph commented 1 year ago

done, ready to close in next rc.

zepumph commented 1 year ago

To confirm fixed, please follow steps in https://github.com/phetsims/friction/issues/314#issue-1509470232 and feel free to close.

Nancy-Salpepi commented 1 year ago

I no longer hear "close" at all in rc.4

FYI @jessegreenberg you mentioned in https://github.com/phetsims/friction/issues/314#issuecomment-1371261502 that I should still hear "Toolbar hidden" and "Toolbar shown" but that isn't what happens in the published sims with Voicing.

If that is OK. Feel free to close this issue @zepumph @jessegreenberg

jessegreenberg commented 1 year ago

Oh that is good to know, thanks @Nancy-Salpepi. I believe that the published sims are incorrect and my comment in https://github.com/phetsims/friction/issues/314#issuecomment-1371261502 is best. Happy to have the change but do not feel like we should go back and fix them.

Ill let @zepumph close since he is responsible dev.

zepumph commented 1 year ago

Ok. I believe I should close this then. Thanks all!