phetsims / ratio-and-proportion

"Ratio and Proportion" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

Name responses firing incorrectly when changes are made with the keyboard (arrow keys) #551

Open terracoda opened 1 year ago

terracoda commented 1 year ago

Both the indy hand sliders and the left and right number spinners are firing a name response while making changes with each press of an arrow key.

According to the design documentation and the responses that are implemented for GFLB (sliders and number spinners) a name response is not supposed to fire upon making a change with alternative input.

The voicing design documentation for RaP's number spinners are explicit and say "No Name Response" with alt input. I see in the design documentation for the indy hands is less specific. That said, I don't think the documentation is the reason why we have this bug. In the actual delivered experience, the firing of the name response is effectively the same for both mouse and keyboard.

To be clear, we should only hear the name response on keyboard focus for alternative input. And not while actively making changes. The voicing of the name response is correctly implemented for mouse input. And the voicing of name responses is also correctly implemented for both mouse and keyboard for the Both Hands interaction. I haven't tested anything else.

I am wondering if a regression has been introduced or if some decision we made when exploring camera input has affected the voicing of the name response for alternative input on the indy hands and the number spinners. I did a quick search of closed issues, but I didn't find anything related. I have to admit my skills for searching past issues are not top notch.

Here's a link to and screenshot RaP's number spinner voicing design

Note: Columns 4 and 2 are the same.

Screen Shot 2023-04-16 at 10 13 37 AM image

Here's a link to RaP's Indy slider designs:

I totally understand that the documentation for the indy hands appears less clear (it's complicated with the 3 tick mark modes), but functionally, the sliders' name responses work the same as the name responses do in Gravity Force Lab:Basics sphere position sliders.

zepumph commented 1 year ago

That does seem like a bug, but I will need some time to investigate this.