search

phetsims / reactants-products-and-leftovers

"Reactants, Products and Leftovers" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 4 forks source link

modify game flow so that "Try Again" is optional? #37

Closed pixelzoom closed 9 years ago

pixelzoom commented 9 years ago

In phetsims/graphing-lines#47, it was requested to change the game flow so that the "Try Again" button automatically changed to "Check" when interacting with game.

In RPAL, the only thing that's interactive is the "Try Again" button. The spinners are converted to read-only numbers (see screenshot below). So we'd need to keep the spinners interactive.

screenshot_567

pixelzoom commented 9 years ago

In phetsims/graphing-lines#47 (comment), @ariel-phet stated that this should be "an open question for the design team". Assigning to @ariel-phet to decided who from the design team should be assigned to answer this question.

pixelzoom commented 9 years ago

Design question: In addition to clicking on the "Try Again" button... Specifically which interactions make the "Try Again" button disappear? Clicking anywhere on the screen? Or clicking on a spinner?

pixelzoom commented 9 years ago

I discussed the Area Builder game with @jbphet. The intent was to make the "Try Again" button disappear when the user did anything to change their answer. Is that also appropriate for this sim? If so, spinners will remain enabled, and the "Try Again" button will disappear when the user interacts with any spinner.

pixelzoom commented 9 years ago

In https://github.com/phetsims/graphing-lines/issues/47#issuecomment-135893275, @amanda-phet confirmed that the desired behavior for Area Builder and Graphing Lines is to make the "Try Again" button automatically disappear when the user changes their answer (or presses the "Try Again" button). Since the impetus for this issue was to make behavior consistent across sims, I assume that this sim should behave in the same way.

So the requirements for this sim are:

(1) keep the spinners interactive when "Try Again" button is visible, and (2) automatically replace the "Try Again" button with the "Check" button when the user interacts with a spinner or presses the "Try Again" button.

@ariel-phet I'll assigning this to myself and will address it soon (likely at the same time as phetsims/graphing-lines#47). If the above requirements are incorrect/incomplete, please let me know asap.

pixelzoom commented 9 years ago

Game behavior has been changed as requested, see this dev version:

http://www.colorado.edu/physics/phet/dev/html/reactants-products-and-leftovers/1.1.0-dev.1/reactants-products-and-leftovers_en.html

@ariel-phet Would you mind verifying (or assigning to someone to verify) since the original team lead is no longer with the project?

pixelzoom commented 9 years ago

Hi @amyh-phet, @ariel-phet tells me you're the new lead on this sim. Could you please review the fix for this issue? Thanks!

amyh-phet commented 9 years ago

Hi @pixelzoom. The fix for the issue looks great. It looked like the new game behavior is only applied to the first level of the game - correct?

pixelzoom commented 9 years ago

No, the change is applied to all levels of the Game -- if you interact with the spinner, the "Try Again" button automatically changes to "Check". Are you seeing something different on Levels 2 & 3?

amyh-phet commented 9 years ago

@pixelzoom. I just looked at the dev version again. Looks good. All levels have active spinners that change "Try Again" to "Check" if you interact with the spinner. I think we are good!

pixelzoom commented 9 years ago

Great, thanks @amyh-phet. Closing this issue.