search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Deploy 1.4.0-rc.2 #117

Closed jessegreenberg closed 6 years ago

jessegreenberg commented 6 years ago

To track what needs to be done for 1.4.0-rc.2. See https://github.com/phetsims/QA/issues/66 for previous RC.

jessegreenberg commented 6 years ago

Check status of build process to make sure we are clear for deploy-rc.

On slack, got verification that we should be OK. @jonathanolson said

Should be fine to use the normal checklist for things tonight, I don't believe anything should be broken or significantly different And let me know if you run into any issues. I think @mattpen upgraded some handling for how build-server requests get made

jessegreenberg commented 6 years ago

cherry pick commits for help dialog updates (phetsims/a11y-research#62)

I would like to get review comments from a few more assignees before proceeding.

jessegreenberg commented 6 years ago

We got all the 👍 we need in https://github.com/phetsims/a11y-research/issues/62, I think we are ready to go!

jessegreenberg commented 6 years ago

I tried to cherry-pick commits in for dialog changes but ran into too many merge conflicts, will have to grab a few more in between the ones listed in https://github.com/phetsims/resistance-in-a-wire/issues/117#issue-275890400.

jessegreenberg commented 6 years ago

Done, https://github.com/phetsims/resistance-in-a-wire/commit/e46c2a4905ef29bd7f6587c67d80a3037294df34 isn't necessary on the release branch.

jessegreenberg commented 6 years ago

We are ready for a spot check RC.

jessegreenberg commented 6 years ago

RC was deployed and verification issue opened, closing this issue.

jessegreenberg commented 6 years ago

https://github.com/phetsims/QA/issues/73