phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Focus incorrectly managed when using mouse + keyboard #119

Closed jessegreenberg closed 6 years ago

jessegreenberg commented 6 years ago

From https://github.com/phetsims/QA/issues/73

@phet-steele found that this sim is susceptible to https://github.com/phetsims/scenery/issues/713. It is particularly obvious when interacting with the PhET menu. Steps to reproduce buggy behavior:

jessegreenberg commented 6 years ago

Actually, it looks like for this sim, this is a buggy implementation for the current implementation of handling keyboard + mouse interaction with the PhET menu. When the PhET menu is shown, we have

        // make sure that any previously focused elements no longer have focus
        Display.focusProperty.set( null );

this removes the focus highlight, but does NOT blur the active element.

jessegreenberg commented 6 years ago

@phet-steele I believe this is resolved in master, would you please verify?

phet-steele commented 6 years ago

Verified!