search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Incorrect relative description when r is much much larger than other letters #129

Closed jessegreenberg closed 6 years ago

jessegreenberg commented 6 years ago

From phetsims/qa#92, @terracoda said

The only description that I was not expecting was this one where there are three explicit "much much larger than"'s. All three sliders are different, and R is so huge it is off screen. I don't think have a better way to handle this edge case, so I think we have to go with "much much larger" across the equation phrase.

Thanks for the report @terracoda, it should say

"Size of letter R is much much larger than the size of letter rho, letter L, and letter A."

terracoda commented 6 years ago

@jessegreenberg, yes, that is what it should say. If the comparison is all the same, it is better not to repeat the phrases.

jessegreenberg commented 6 years ago

The problem is that rho, L, and A scales are not at comparable levels, but the pattern used needs to describe them as such.

jessegreenberg commented 6 years ago

Should be fixed in the above commit. Thanks @terracoda, closing.