search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

NVDA stutters on equation when rho is small and A is stuttered when being controlled #175

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Device Dell Laptop OS Win 10 Browser Firefox Problem Description For phetsims/QA/issues/183 There are some stutters when using the NVDA screen reader. The first occurs when R and rho are small and the screen reader is describing the equation. Other states of the equation do not seem to create this stutter so far as I have discovered. In addition, when manipulating A the screen reader stutters over A itself. Steps to reproduce

  1. Turn on NVDA with Firefox
  2. Adjust rho so that it is much smaller than L and A. Some small adjustments can be made to the other values, as can be seen with L in the video.
  3. Set the screen reader to describe the equation and listen to the size comparisons
  4. Use keyboard nav to adjust the A slider to hear that particular stutter.

Screen capture https://drive.google.com/file/d/1AkQyl84E28N_h4AhZcr_D47iu6R3zQSb/view?usp=sharing https://drive.google.com/file/d/1aG7S2R7YdAw8yYn1IxdFfALouNgsHovq/view?usp=sharing

zepumph commented 5 years ago

I'm terribly sorry. I can't hear the stutter. Honestly it sounded normal to me. @jessegreenberg can you hear it?

KatieWoe commented 5 years ago

The one primarily described is in the second video I believe. The word the is repeated before L.

jessegreenberg commented 5 years ago

Good ear @KatieWoe! To me it sounds like repetition of the word "than".

jessegreenberg commented 5 years ago

Here it is in the PDOM: image

jessegreenberg commented 5 years ago

I think the problem is the "than" in lAndAComparablePatternString: 'Size of letter R is {{rToRho}} the size of letter rho, and {{rToLAndA}} than letter L and letter A.'

because the size comparison strings all have "than" already.

jessegreenberg commented 5 years ago

This was my fault @zepumph, so sorry :(

I went ahead and removed it and played with the sim, I think this is safe. Can you please review? I don't think there was a combination that was using that extra "than" but can you please verify before we merge with master?

zepumph commented 5 years ago

We will not be pulling this into the 1.5 rc. If this has been confirmed fixed in master it can be closed.