search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

NVDA Keyboard Nav Button and Phet Menu read as same button #176

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Device Dell Laptop OS Win 10 Browser Firfox Problem Description For phetsims/QA/issues/183 First noticed by @lmulhall-phet. When NVDA is reading through the controls it seems to treat the Keyboard Nav Button as being the same as the PhET Menu, and reads them one right after the other while only highlighting the Keyboard Nav button. This only seems to be the case when reading through the sim description. When tab is used to navigate with keyboard nav its self and NVDA is reading, the PhET menu is easily selected by itself. Steps to reproduce

  1. Use NVDA on Win 10 Firefox.
  2. Using keyboard commands to read the sim description (not to navigate the controls) read through the whole description
  3. The sim will highlight the reset all button when that area of the description is reached
  4. Use the keyboard to advance to the next dialog
  5. The keyboard nav description button will be highlighted but both it, and the PhET menu will be read
  6. Attempt to advance to the next dialog with the keyboard. The same behavior as step 5 will occur.

Screen Capture (also showing keyboard inputs) https://drive.google.com/file/d/11pc6FvyPoREjfCpWCzROLsQ2SvJl1jK5/view?usp=sharing

zepumph commented 5 years ago

I took this for a spin to hear it with chrome and firefox (NVDA), and found the same thing with both. I can confirm that I hear the same thing you do @KatieWoe, except here is my take.

I think the title is a little bit different what what is happening

NVDA Keyboard Nav Button and Phet Menu read as same button

I actually hear two individual buttons each time, they are just described in the same key press. This is because they are both surrounded in a div with role=region. So as you arrow down, I guess everything in that region is read out to you. It is confusing though because although it is reading the whole region, the focus is just on the keyboard shortcuts button. Furthermore, you are at the last element on the screen, so each time you press the down arrow, it just repeats reading the "region div".

To me this seems to be a UX and design question for @terracoda. I don't think there is a bug, as the code is running (I believe) as expected. @terracoda will you please look into the desired behavior of this, I'm happy to pair if you need to see it on NVDA.

Also tagging @jessegreenberg as I'm unsure how much he knows about the sim resources section. I think I was involved pretty little in that.

terracoda commented 5 years ago

@KatieWoe, @lmulhall-phet, I agree with @zepumph that this is not a bug and just a quirk about how controls within a grouping region are read out inside that region (edited for clarity).

I don't like that the H2: "Sim Resources" sounds like it is outside the region.

I think there are some structural changes coming for the bottom bar, so I think we can defer more testing on this when that change happens.

I don't think this is should be a blocking issue, and it should not preset a usability issue for users. There are clearly 2 controls there from a screen reader user's perspective.

terracoda commented 5 years ago

Back to you @zepumph. Can we close this one?

terracoda commented 5 years ago

I am re-opening this issue. Based on 2 interviews with Friction, this seems to be an issue for blind users.

But maybe it makes the best sense to move this issue to the A11y Research repos as it affects all sims?

terracoda commented 5 years ago

I am adding this item to Tuesday's A11y Dev/Design meeting, and I'll tag folks so they have a heads up: @jessegreenberg, @zepumph, @mbarlow12, @emily-phet, @elharden2

zepumph commented 5 years ago

@terracoda I think you should create an issue in a11y research and then link this issue to it. I think these large ideas/design changes work best when not tied to a bug report from QA for a single sim.

terracoda commented 5 years ago

Closing this issue again. It will be addressed in https://github.com/phetsims/a11y-research/issues/121 .