phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Is the read out for minimum length supposed to be 0.00...01? #177

Closed ghost closed 6 years ago

ghost commented 6 years ago

Here's what JAWS sounds like when it reads the "Slider Controls" h3:

https://drive.google.com/open?id=1-IBXvhnGrQo0n4jlHKwDEd5MomSDyFMl

For https://github.com/phetsims/QA/issues/179 https://github.com/phetsims/QA/issues/183.

jessegreenberg commented 6 years ago

That sounds incorrect, its reading the value of the "Length" slider, and it sounds like the formatting isn't right.

jessegreenberg commented 6 years ago

Oh, for some reason it is reading the "min" and "max" values for the slider? I have never heard that before. he min value in the PDOM is min="0.1", so I am confused about where it is getting "0.00000.....1.

jessegreenberg commented 6 years ago

Hearing the recording again, it is saying "min 0.100...001", so it is a precision issue maybe.

jessegreenberg commented 6 years ago

Likely a problem with AccessibleSlider so assigning to myself.

jessegreenberg commented 6 years ago

I don't see anywhere where the "min" attribute could pick up extra decimals in toFixed calls or something, inspection in the console shows that min value is 0.1.

I am not hearing this in JAWS with FF 62, but JAWS isn't reading min and max values for the slider when it receives focus. Ill see if I can figure out how to turn that on in user settings or something.

jessegreenberg commented 6 years ago

OK, I hear it now, only happens when reading through with the virtual cursor (not on focus). Here is the HTML for the slider:

<label tabindex="-1" id="label-247-310-321-388-387-386-346-349" for="247-310-321-388-387-386-346-349">L, Length</label>
<input style="width: 1px; height: 1px;" id="247-310-321-388-387-386-346-349" tabindex="0" role="slider" aria-orientation="vertical" step="0.1" min="0.1" max="20" aria-valuetext="10.00 centimeters" type="range">

Ill try to reproduce in a JSFiddle.

jessegreenberg commented 6 years ago

I was able to reproduce in this JSFiddle: https://jsfiddle.net/au7rhbg8/

Ill start removing attributes until the problem goes away. (if it goes away)

jessegreenberg commented 6 years ago

Seems to just happen for some "min" values for sliders. For example, this slider with min=0.3 reads the min value (only when using the virtual cursor) as "0.299999....". I think that we should submit a bug report to VFO, add to the list of AT quirks, and close this issue.

@terracoda @zepumph what do you think?

jessegreenberg commented 6 years ago

Here is a very basic slider where the bug is coming up, Ill probably use this one in the bug report.

jessegreenberg commented 6 years ago

I went ahead and reported https://github.com/FreedomScientific/VFO-standards-support/issues/112. I documented in our internal tracking https://docs.google.com/document/d/1518zv6F0odExFsodShZxwTmWNQk3civuNwtQUR-rEBs/edit. OK to close this issue?

ghost commented 6 years ago

If you think we’re done, then it’s OK to close from QA’s standpoint. But perhaps @terracoda and @zepumph will have something to say, so I’ll leave it open for now.

zepumph commented 6 years ago

Sounds good to close. @jessegreenberg isn't there a place to document this sort of weirdness so qa has a list of know bugs to check before submitting issues to developers? I would recommend adding this there.

jessegreenberg commented 6 years ago

There is, sorry I mentioned in an edit to https://github.com/phetsims/resistance-in-a-wire/issues/177#issuecomment-419655417 that I added a note there.

jessegreenberg commented 6 years ago

Alright we have 👍 s from everyone so I think we can close!

KatieWoe commented 4 years ago

Does happen in https://github.com/phetsims/QA/issues/476, but not always consistently.

KatieWoe commented 3 years ago

https://drive.google.com/file/d/1hexjqYRExi6u7Doq8CGbOSHKlDqNFM3y/view?usp=sharing Seen with values in https://github.com/phetsims/QA/issues/582 when tick marks are on.

zepumph commented 3 years ago

Sounds right, I don't see any progress on the Freedom Scientific issue.