search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Why does the focus highlight for the reset button have a stroke? #186

Closed jbphet closed 5 years ago

jbphet commented 5 years ago

With one exception, all all focus highlights in this sim are a simple shape with no stroke, like this one for one of the sliders:

riaw-slider-highlight-2

However, there is a stroke on the highlight when the reset button is selected, shown here:

riaw-slider-highlight

This looks a bit odd to me, and IMO would look better if it was consistent with the other highlights. I searched through GitHub and couldn't find any issues that seemed to describe why this is like this (which isn't to say that there aren't any, I just couldn't find them). Is there a good reason why this one focus highlight is unique?

jessegreenberg commented 5 years ago

When the resistance is very large it is difficult to see the pink focus highlight on top of the red letter, so a black stroke was added to help with visibility.

Here is the related issue: https://github.com/phetsims/resistance-in-a-wire/issues/118

Reassigning to you @jbphet.

jbphet commented 5 years ago

Okay. Seems like a reasonable explanation. Closing.