phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Clicking out of keyboard nav moves sliders Edge #196

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Test device: Dell Laptop Operating System: Win 10 Browser: Edge Problem description: For https://github.com/phetsims/QA/issues/219#event-1953042350 When using keyboard nav on the sliders, clicking out with a mouse will cause the slider that was being controlled to jump up. Steps to reproduce:

  1. Go to the sim in edge
  2. Use keyboard nav to manipulate the first slider (not exclusive to this slider)
  3. Put the slider somewhere in the middle with shift arrow to make the effect easier to see
  4. Use the mouse to select the mute button (or anything to stop the keyboard nav

Screenshots: https://drive.google.com/file/d/1vA-gLGyV9gygHpTIcsKCK_pomXnW6hyE/view?usp=sharing

Troubleshooting information (do not edit):

Name: ‪Resistance in a Wire‬ URL: https://phet-dev.colorado.edu/html/resistance-in-a-wire/1.6.0-rc.1/phet/resistance-in-a-wire_en_phet.html Version: 1.6.0-rc.1 2018-11-07 18:26:25 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36 Edge/17.17134 Language: en-US Window: 1920x946 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 Vendor: Microsoft (Microsoft Edge) Vertex: attribs: 16 varying: 30 uniform: 4096 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 32767x32767 OES_texture_float: true Dependencies JSON: {"assert":{"sha":"928741cf","branch":"HEAD"},"axon":{"sha":"ff00a0bb","branch":"HEAD"},"brand":{"sha":"1fd6682e","branch":"HEAD"},"chipper":{"sha":"fa2fbadf","branch":"HEAD"},"dot":{"sha":"bbbd8526","branch":"HEAD"},"joist":{"sha":"82521d0c","branch":"HEAD"},"kite":{"sha":"380cef53","branch":"HEAD"},"phet-core":{"sha":"1b90ac2f","branch":"HEAD"},"phet-io":{"sha":"38d7b161","branch":"HEAD"},"phet-io-wrapper-classroom-activity":{"sha":"246085c1","branch":"HEAD"},"phet-io-wrapper-hookes-law-energy":{"sha":"7479b0ec","branch":"HEAD"},"phet-io-wrapper-lab-book":{"sha":"c46f7839","branch":"HEAD"},"phet-io-wrappers":{"sha":"a6bc62ca","branch":"HEAD"},"phetcommon":{"sha":"cd63d89a","branch":"HEAD"},"query-string-machine":{"sha":"06ed6276","branch":"HEAD"},"resistance-in-a-wire":{"sha":"38ae25d0","branch":"HEAD"},"scenery":{"sha":"51716674","branch":"HEAD"},"scenery-phet":{"sha":"15dec251","branch":"HEAD"},"sherpa":{"sha":"2cd50500","branch":"HEAD"},"sun":{"sha":"5244d45e","branch":"HEAD"},"tambo":{"sha":"ad355580","branch":"HEAD"},"tandem":{"sha":"4f37a910","branch":"HEAD"}}
KatieWoe commented 5 years ago

Did not seem to occur in full screen.

jessegreenberg commented 5 years ago

I actually think this might have already been fixed by https://github.com/phetsims/sun/issues/413, I can't get this to happen in master. @KatieWoe can you please confirm?

KatieWoe commented 5 years ago

@jessegreenberg does seem to be fine on master.

jessegreenberg commented 5 years ago

Thanks @KatieWoe reassigning to me to track for next RC.

jbphet commented 5 years ago

@jessegreenberg - I need to put out the next RC, and this issue is still occurring the the latest version on the RIAW 1.6 release branch. I looked at the issue that you linked about, and there are several commits and I'm not sure which ones to pull over, so I think I'll need you to do it. Marking as high priority since we need to get the next RC out.

jessegreenberg commented 5 years ago

Sounds good @jbphet, I merged the two last commits in that issue into the resistance-in-a-wire-1.6 branch in sun (the one above and https://github.com/phetsims/sun/commit/d4feeef3e2f9e7f26221ccfab52d5bcb6ece1dff). I verified that the problem is fixed in the 1.6 branch of RIAW by making sure that sliders no longer move in Edge when clicking in the sim or tabbing away from the thumb. And I tested with NVDA in Firefox to make sure that NVDA no longer says "Invalid" when slider values change.

Reassigning to you so you are aware this one is ready.

jbphet commented 5 years ago

Should be fixed in 1.6.0-rc.2, unassigning for now.

KatieWoe commented 5 years ago

This looks fixed in 1.6.0-rc.2