phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Significant iPad Performance issues #200

Closed KatieWoe closed 5 years ago

KatieWoe commented 5 years ago

Moved from https://github.com/phetsims/resistance-in-a-wire/issues/198 per @jbphet. For https://github.com/phetsims/QA/issues/219. iOS 12, and to a lesser extent 10, has significant performance issues. When using the profiler querry parameter I saw the frame rate on iOS 12 drop as low as 15. This occurred on the published sim as well, though less drastically. iOS 10 crashed while using profiler but did not when the querry parameter was off. As iOS 12 is our latest OS on a newer iPad, this performance is particularly bad. It is most noticeable while manipulating sliders, and seeing the slider lag behind the finger dragging it. It also seemed to have moments of good performance before dropping again.

KatieWoe commented 5 years ago

Clarification per @ariel-phet. Poor performance is present without profiler. Lag felt about the same with and without it turned on. Profiler may have made it slightly worse as there was at least one crash with it on. Profilier was used to quantify lag.

jbphet commented 5 years ago

I tried the sim on several iOS devices, and the sim seems usable to me on all. It definitely has some pauses, probably due to garbage collection. I profiled it in the Chrome developer tools on my Windows 10 machine, and it looks like the new a11y code is adding a bit more time in each animation frame. I don't think there is anything quick that we can do on this, so I'm going to move ahead with the next RC on the 1.6 release branch and will have others evaluate and decide if the performance is acceptable.

jbphet commented 5 years ago

Assigning to @ariel-phet to take a look at the performance and make the judgement call as to whether to invest time and effort into improving this.

jbphet commented 5 years ago

@ariel-phet looked at the performance on an iPad 2 and said that it is acceptable. Closing.