Update credits - Githubissues

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.

http://phet.colorado.edu/en/simulation/resistance-in-a-wire

GNU General Public License v3.0

1 stars 4 forks source link

Update credits #208

Closed terracoda closed 3 years ago

terracoda commented 5 years ago

From https://github.com/phetsims/a11y-research/issues/134

The credits for this sim are missing a few people:

Emily Moore and Taliesin Smith need to be added to the Team list
Sound designers are missing, too.

Reaching out to @Ashton-Morris and @emily-phet. Are Mike Winters and Ashton Morris the sound designers for this sim?

terracoda commented 5 years ago

Once we have all the names, please assign to @jbphet and mark as Priority 3.

terracoda commented 5 years ago

@emily-phet, could you verify the sound designers for Resistance in a Wire?

emily-phet commented 5 years ago

@Ashton-Morris and @mikewinters10

samreid commented 5 years ago

Assigned to responsible dev @zepumph to add soundDesign: 'Ashton Morris, Mike Winters', to the credits.

terracoda commented 5 years ago

@zepumph, the A11y Team still needs to be added, too. Current Screen Shot of Published Sim:

Please add bolded names to Team without bold of course ;-):

Team: Wendy Adams, Mindy Gratny, Emily Moore, Ariel Paul, Taliesin Smith, Brianna Tomlinson

Please add sound designers after QA:

Sound Design: Ashton Morris, Mike Winters

emily-phet commented 5 years ago

Also - "Brianna Tomlinson" to end of team list.

terracoda commented 5 years ago

@emily-phet, good catch, I added @briannatomlinson to the list in https://github.com/phetsims/resistance-in-a-wire/issues/208#issuecomment-499057633, and will be updating issues for other sims.

zepumph commented 5 years ago

Implemented above, I also converted many usages of "Emily Moore" to "Emily B. Moore". Closing

zepumph commented 5 years ago

Reopening. I should publish a MR so that the proper credits are published.

zepumph commented 4 years ago

I should also add "Emily Moore" to bad text, in preference with Emily B. Moore

terracoda commented 3 years ago

@zepumph, this issue is a bit old, but it has not yet been done. Maybe it fell on your radar? I updated the credits on the web site, adding Emily, myself, Brianna, and Ashton Morris and Mike Winters.

Screen Shot 2020-10-09 at 1 32 18 PM

mikewinters10 commented 3 years ago

Could "Mike Winters" be included as well under sound?

On Fri, Oct 9, 2020 at 12:06 PM Taliesin L. Smith notifications@github.com wrote:

@zepumph https://github.com/zepumph, this issue is a bit old, but it has not yet been done. Maybe it fell on your radar? I updated the credits on the web site, adding Emily, myself, Brianna, and Ashton Morris and Mike Winters.

[image: Screen Shot 2020-10-09 at 1 32 18 PM] https://user-images.githubusercontent.com/1902116/95605716-e7976280-0a33-11eb-9738-c4d0463048a8.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/phetsims/resistance-in-a-wire/issues/208#issuecomment-706267847, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRDVTRS3BBD6KEZZ5PBAM3SJ4YHNANCNFSM4G4G3BRQ .

zepumph commented 3 years ago

Ahh yes @terracoda, thanks for the ping. I just updated the credits on the 1.6 branch and published them to the website. Please review.

https://phet.colorado.edu/sims/html/resistance-in-a-wire/latest/resistance-in-a-wire_en.html

terracoda commented 3 years ago

Looks good, thanks @zepumph! Closing Time!