phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

CT error: t.replace is not a function #215

Closed jessegreenberg closed 4 years ago

jessegreenberg commented 4 years ago
**resistance-in-a-wire : fuzz : built
https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000
Query: fuzz&memoryLimit=1000
Uncaught TypeError: t.replace is not a function
TypeError: t.replace is not a function
at ms (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:286515)
at Object.setTextContent (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:287845)
at Ls.setLabelSiblingContent (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:298316)
at Ls.update (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:292593)
at Fs.initializeAccessibleInstance (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:301639)
at new Fs (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:300882)
at Function.createFromPool (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:21577)
at Object.createTree (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:308307)
at Object.createTree (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:308429)
at Object.createTree (https://bayes.colorado.edu/continuous-testing/ct-snapshots/1588867140172/resistance-in-a-wire/build/phet/resistance-in-a-wire_en_phet.html?continuousTest=%7B%22test%22%3A%5B%22resistance-in-a-wire%22%2C%22fuzz%22%2C%22built%22%5D%2C%22snapshotName%22%3A%22snapshot-1588867140172%22%2C%22timestamp%22%3A1588871481484%7D&fuzz&memoryLimit=1000:908:308429)
id: Bayes Chrome
Snapshot from 5/7/2020, 11:59:00 AM**
jessegreenberg commented 4 years ago

It looks like the wrong export was accidentally set for AccessibleSummaryNode.

jessegreenberg commented 4 years ago

It is also inheriting from AccessibleSectionNode, but the supertype is Node.

jessegreenberg commented 4 years ago

@zepumph just got it in https://github.com/phetsims/resistance-in-a-wire/commit/73ec198497a4aba8a686c782948434d1d999210d, thanks!