search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

some references to resistance-in-a-wire/js/view/shape-views/slider-box-view/slider.js are miscapitalized #47

Closed olleicua closed 8 years ago

olleicua commented 10 years ago

references are made to Slider.js that break the sim on case sensitive file systems.

samreid commented 10 years ago

Thanks @olleicua for this report! I think I have fixed it in the above commits, can you pull and verify? Thanks again!

olleicua commented 10 years ago

Unfortunately I cannot easily do that. I cloned all of the dependent repos into a my own project but with the .git directories my project treats them as modules and will point to these repos in the future. My project needs to be stable so I deleted the .git directories. I used sym links to solve the problem in my project so the fix doesn't effect me dirrectly. I don't feel like going through the process of manually figuring out which repos to clone again. If you can recommend a good way to grab all of the dependent repos at once then I will happily test this for you. If you don't have such a solution I recommend in the future you put interdependent code like this in a single repo.

Also, there were a few other miscapitalizations. I don't recall where all of them were. I recommend always using lower case file names.

ariel-phet commented 8 years ago

@jbphet might be good to verify if this issue can be closed.

jbphet commented 8 years ago

I searched through the code and it looks like @samreid fixed all occurrences. Closing.