phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Issues with String Tests #63

Closed elisemorgan closed 8 years ago

elisemorgan commented 8 years ago

Related to https://github.com/phetsims/tasks/issues/479

Test device: Personal Mac

Operating System: OS X 10.10.5

Browser: Chrome 47.0.2526.106

Problem description: Issues with Long strings. Minor detail in rtl test, don't know if it is significant.

Steps to reproduce: Perform string tests

Severity:

Screenshots: Long: screen shot 2016-01-15 at 1 20 00 pm

rtl: screen shot 2016-01-15 at 1 21 05 pm

Troubleshooting information (do not edit): Name: ‪Resistance in a Wire‬ URL: http://phettest.colorado.edu/resistance-in-a-wire/resistance-in-a-wire_en.html?ea&brand=phet&showPointerAreas Version: 1.2.0-dev.1 (require.js) Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.106 Safari/537.36 Language: en-US Window: 1268x653 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 15 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 16) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

elisemorgan commented 8 years ago

@jbphet double string test related to https://github.com/phetsims/tasks/issues/531 screen shot 2016-03-02 at 11 17 36 am

jbphet commented 8 years ago

I did some investigation on this and the problem is unique to pattern strings. It can be eliminated by turning on the call to simplifyEmbeddingMarks in StringUtils.format (currently only called when running on the Edge browser). However, this would have some effect on performance, and since doubling of strings in patterns is not something that real world users - including translators - are ever going to do, we should just see this as a non-issue. I'm going to label this as "won't fix" and close.

jbphet commented 8 years ago

By the way, I tested this on Win10 + Chrome, Firefox, and Edge and the problem did not occur there. I was only able to reproduce on iOS 9.2.1. I didn't try it on OSX.