search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Area and radius of the wire #70

Closed jonathanolson closed 7 years ago

jonathanolson commented 8 years ago

It's bugging me that the displayed area is not at all proportional to the area slider.

The area slider controls the radius of the wire (not area), so the displayed area is the square of what is shown in the slider. This makes it off by a factor of 5 or so.

Should this be ignored?

ariel-phet commented 8 years ago

It should be ignored for now, at some point we will go back and do a thorough code review of RIAW (likely when ready for instrumenting) and we can address then. Marking as priority deferred and clearing assignee

ariel-phet commented 7 years ago

@zepumph, @phet-steele pointed out that this should probably be taken care of (note the old comment above). You and I can work on polishing it, but basically I would keep the maximum "visual size" the same and we can do a proper scaling so the radius shrinks down properly (but nowhere near as small as now)

zepumph commented 7 years ago

Ignore the commit and revert from phet-io-wrappers above, oops. I made it so that the diameter of the wire is accurate to the formula. @ariel-phet please pull master and see how you like it.

ariel-phet commented 7 years ago

Pulled and looks good! Closing

ariel-phet commented 7 years ago

thanks @zepumph