phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

Release new version for phet and phet-io brand #88

Closed zepumph closed 6 years ago

zepumph commented 7 years ago

from https://github.com/phetsims/QA/issues/4#event-1139529251, it would be good to do a dev release first. I will do one for phet-io, and then create RC's for the phet and phet-io versions.

I should do these first:

zepumph commented 7 years ago

After talking with @ariel-phet, we think the best approach to get both a phet-io and phet brand published is to do the following three qa tests:

  1. phet brand dev release
  2. phet brand rc
  3. phet-io rc
zepumph commented 7 years ago

Alright the dev version is ready

zepumph commented 7 years ago

https://github.com/phetsims/QA/issues/16

zepumph commented 7 years ago

Make sure to update credits before publishing

zepumph commented 7 years ago

Issues to tackle before RC:

zepumph commented 7 years ago

I made some substantial changes in #91, and I will do another dev test before going to RC.

zepumph commented 7 years ago

phet-io dev test: https://github.com/phetsims/QA/issues/32

phet-steele commented 7 years ago

@zepumph don't forget #96 either!

jessegreenberg commented 7 years ago

@zepumph what is the status of this issue? We are ready to deploy a PhET brand RC of this sim with keyboard navigation, should we coordinate?

zepumph commented 7 years ago

I think there is just https://github.com/phetsims/ohms-law/issues/68 (which effects RIAW as well). I would love some help on it, I think it has to do with some layout changes I did earlier in the summer, but I can't track down the problem.

jessegreenberg commented 7 years ago

Ok, thanks @zepumph. Does that need to be fixed before a redeploy? Does the currently deployed version have that issue as well?

zepumph commented 7 years ago

I don't think it is in the latest version on phet. I'll take another look at it and see what I can do.

zepumph commented 7 years ago

https://github.com/phetsims/ohms-law/issues/68 is fixed, and we are ready for a release. I'm not sure if we should do a PhET-iO version now, since there seems to be no request for it. @samreid do you think we should release RIAW for phet-io right now too?

samreid commented 7 years ago

It is up to @kathy-phet.

samreid commented 7 years ago

On second thought, If the sim is improved, it seems we should also test and publish the phet-io one too.

zepumph commented 7 years ago

@samreid how stable do you think master is right now due to https://github.com/phetsims/phet-io/issues/1223. Should we worry?

samreid commented 7 years ago

It still needs attention and should be considered unstable. You could grab an estimate earlier sha or wait unit it is resolved

zepumph commented 7 years ago

I think that resolution sounds like a good idea. I will crank away at some of them, and try to get it more stable so we can figure out if that's the way we want to go definitively.

zepumph commented 7 years ago

@jessegreenberg think that master is more stable now for an RC

jessegreenberg commented 7 years ago

Thanks @zepumph!

jessegreenberg commented 7 years ago

A phetio rc was deployed for testing here: https://github.com/phetsims/QA/issues/53

Once it passes testing, phet branded version will use the same SHAs.

zepumph commented 7 years ago

Unassigning, let me know how I can help.

jessegreenberg commented 7 years ago

@zepumph in #107 we decided not to include keyboard nav in phet-io releases until a11y features work with PhET-iO. So the current plan is to deploy 1.3-phetio without keyboard nav and then a 1.4 PhET brand version with keyboard nav. Does that sound correct?

zepumph commented 7 years ago

That sounds like our current plan, although it is kinda a pain in the butt. I want to double check with @samreid. Sam does this seem right to you?

samreid commented 7 years ago

Perhaps we should defer further phet-io releases until we get Faraday's Law stabilized and have PhET-iO design meetings for each sim?

zepumph commented 7 years ago

That would be a question for @kathy-phet, using the old way of instrumenting. OL and RIAW are both ready for phet-io releases. The question is should we spend the QA time to do this if we will just need to republish a "stable" version soon.

zepumph commented 7 years ago

@kathy-phet should we proceed with RIAW phet-io release even though it has not had design time to move it to a "stable api?"

zepumph commented 6 years ago

phetio 1.3.0-phetio released! https://phet-io.colorado.edu/sims/resistance-in-a-wire/1.3.0-phetio/wrappers/index/

zepumph commented 6 years ago

@jessegreenberg you are taking on the phet version in a different issue and a different version (since it has accessibility enabled by default). Closing.