search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

QA Credits #89

Closed phet-steele closed 7 years ago

phet-steele commented 7 years ago

This sim is void of QA credits.....let's add them!

Steele Dalton, Bryce Griebenow, Elise Morgan, Oliver Orejola, Benjamin Roberts, Bryan Yoelin

@zepumph, please do not close until 1.3 is published, but feel free to add these now.

For phetsims/QA/issues/16.

zepumph commented 7 years ago

@phet-steele let me know if this looks good to you.

phet-steele commented 7 years ago

@zepumph it's good, but we need more now. Alex Dornan, Ethan Johnsonas well, please. You'll probably have to put a line break in there somewhere.

zepumph commented 7 years ago

Thanks @phet-steele, closing

phet-steele commented 7 years ago

You didn't preserve the alphabetic sorting 😛 . Fixed it myself but totally referenced the commit to the wrong issue above because that's how I roll.

zepumph commented 7 years ago

Oops sorry, this commit here fe7aafe

zepumph commented 7 years ago

because of https://github.com/phetsims/joist/issues/435, we don't need the newline anymore. Should be good now!