search

phetsims / resistance-in-a-wire

"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1 stars 4 forks source link

No max width on the slider value text #97

Closed phet-steele closed 7 years ago

phet-steele commented 7 years ago

@zepumph I'm not entirely convinced that this is important to address.

Editing these three tandems...

resistanceInAWire.resistanceInAWireScreen.resistanceInAWireScreenView.controlPanel.resistivitySlider.valueText
resistanceInAWire.resistanceInAWireScreen.resistanceInAWireScreenView.controlPanel.lengthSlider.valueText
resistanceInAWire.resistanceInAWireScreen.resistanceInAWireScreenView.controlPanel.areaSlider.valueText

...and making the text long enough pushes sliders out of the panel. It seems there is no max width where there should be.

screen shot 2017-08-07 at 10 30 05 am

Seen on macOS 10.12.6 Chrome. For phetsims/QA/issues/32.

zepumph commented 7 years ago

Thanks @phet-steele. Good catch.

phet-steele commented 7 years ago

@zepumph, still some slight movement, but the movement stops after the text reaches a certain length. Probably just the the maxWidth is slightly too large. Not too concerned for the initial dev release.

zepumph commented 7 years ago

This is fixed now, I wasn't setting the maxWidth of the SliderUnits correctly. Closing