issues
search
phetsims
/
resistance-in-a-wire
"Resistance in a Wire" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/resistance-in-a-wire
GNU General Public License v3.0
1
stars
4
forks
source link
issues
Newest
Newest
Most commented
Recently updated
Oldest
Least commented
Least recently updated
Factor out font name Verdana
#19
samreid
closed
11 years ago
0
Fix file name upper/lower for files that return a constructor function.
#18
samreid
closed
11 years ago
0
Translations not being displayed
#17
samreid
closed
11 years ago
5
Add a README.md file
#16
samreid
closed
11 years ago
0
Please add some documentation in the resistance-in-a-wire.html (about the same amount of documentation as in example-sim.html).
#15
dkras
closed
11 years ago
0
Why did you put the <script data-main="js/resistance-in-a-wire-config.js" src="contrib/require-2.1.2.js"></script> in the <body> in the main html?
#14
dkras
closed
11 years ago
0
Please add 'fastclick' library so reset all button is pressed immediately on the ipad instead of after about 300ms. There is an example of this in Forces and Motion Basics html on github.
#13
dkras
closed
11 years ago
0
Rename the 'shapes' package to something more like 'view'
#12
dkras
closed
11 years ago
0
Consider naming the anonymous functions with an inline name like 'return function Slider(view,x,y,h,targetProperty,img) so that it will appear in the debugger and profiling tools.
#11
dkras
closed
11 years ago
0
Our team prefers variable names like 'totalWidth' to shortened ones like 'totW'
#10
dkras
closed
11 years ago
0
Please rename packages like 'ResistorView' to 'resistor-view' if you can have hyphens in requirejs paths. (If not, then use style like 'resistorview').
#9
dkras
closed
11 years ago
0
It looks like the project needs a package.json file so that grunt will work. I think I added a sample copy of this and the gruntfile in the branch 'review-1'
#8
dkras
closed
11 years ago
0
You can add 'author' annotations into the files if you would like (I guess I noticed them some places but not all places)
#7
dkras
closed
11 years ago
0
I think resistance-in-a-wire\html\reset.html could be moved into the index.html or Javascript if you think that's a good idea.
#6
dkras
closed
11 years ago
0
resistance-in-a-wire/html/README.txt can be deleted
#5
dkras
closed
11 years ago
0
Remove deep copy of phet common and use repo links
#4
dkras
closed
11 years ago
0
Resizing the window can create scroll bars and partially obscure the "reset all button" (Win8+Chrome)
#3
dkras
closed
11 years ago
3
The rho and L symbols fall beneath the division line
#2
samreid
closed
11 years ago
0
Initial code review
#1
samreid
closed
11 years ago
1
Previous