search

phetsims / rosetta

PhET's Simulation Translation Utility
MIT License
3 stars 1 forks source link

Community Contribution sims aren't appearing in Translation Utility #432

Closed oliver-phet closed 1 month ago

oliver-phet commented 3 months ago

This was reported by our _ht Haitian Creole translator.

Rosetta isn't currently displaying Sound Waves or Normal Modes (Community Contribution sims).

Curiously, Sound Waves and Normal Modes currently have several translations. I believe when these were tagged as "prototypes" they were translatable, but when the website was updated with Release Type, these two sims were re-tagged as Community Contributions.

oliver-phet commented 2 months ago

Adding that our Dari translator also asked about this bug - so it is certainly blocking translation of these community sims.

We’re moving forward nicely with the translations into Dari. Thank you so much for that. There is at least one PhET that we can’t find and that we would like to translate. Perhaps because it’s new? Anyway, can you guide us on how we should find it and translate it?

jbphet commented 1 month ago

It looks like a new flag was added to the metadata recently. The flag is isCommunity, and I briefly searched through the website issues and maybe this one - https://github.com/phetsims/website-meteor/issues/608 - is where and when it was added.

Regardless, I wasn't aware of this change, so the Rosetta code didn't handle it. I've added handling for it now and will test it out on phet-server-dev and, if everything looks good, I'll deploy in the live version.

jbphet commented 1 month ago

For reference, this is the SHA where isCommunity was added to the metadata: https://github.com/phetsims/website/commit/7d29f625d560e282688f4569bac1929df75c02e1.

jbphet commented 1 month ago

This should now be fixed and deployed to the live version of Rosetta. For my reference, the SHA which was deployed is 6d8dce20edd10a3de52549cd4a4c83197e9b85ff.

@oliver-phet - Can you please double check that the previously missing sims are now available? Also feel free to assign @solaolateju if we'd like him to verify as well.

oliver-phet commented 1 month ago

Looks good to me (I checked Dari, Haitian, and Abkhazian)

jbphet commented 1 month ago

Cool, thanks for checking it. Closing.