[GrabDragInteraction] Visual Keyboard hint shows up on mobile ios platform

phetsims / scenery-phet

Reusable components based on Scenery that are specific to PhET simulations.

MIT License

8 stars 6 forks source link

[GrabDragInteraction] Visual Keyboard hint shows up on mobile ios platform #704

Open terracoda opened 3 years ago

terracoda commented 3 years ago

I just noticed I get the keyboard hint for the grab button when using my iphone. The spoken content and hints delivered through VoiceOver are correct.

Yellow Balloon, movable
PDOM Help text: Double tap and hold to grab Yellow Balloon. Lift to release.
Upon first grab correct platform-specific help text: Yellow Balloon, Grabbed. At center of Play Area. Has no more negative charges than positive charges. Drag finger to move balloon. Lift to release.
Upon subsequent grabs, correctly does not provide help text: Yellow Balloon, Grabbed. {{position}}. {{comparative-charges}}.

In addition to platform-specific help text, please make the visual keyboard platform specific as well. The visual keyboard hint should not appear on iOS (mobile platform).

terracoda commented 3 years ago

This should be part of the common-code mobile grab button.

jessegreenberg commented 3 years ago

This is related to the mobile grab-and-drag work, but we decided that this publication of BASE will not support this so I don't think this is blocking publication anymore and this is being deferred.

terracoda commented 3 years ago

Correct, we are deferring the publication of BASE with VoiceOver accessibility on iOS devices (i.e., mobile accessibility). In the interim, BASE is listed with mobile accessibility in the prototype section on the Accessible Simulations page.

zepumph commented 3 years ago

One thing to do here is to see if GFL on master is broken like this (since it has the grab drag interaction and has been published with mobile a11y). That would make it known if we need to adapt each new sim, or if something in common code is broken.

zepumph commented 3 years ago

We may want to move this to common code. Marking undeferred so that I can work on this to fix for friction.

zepumph commented 3 years ago

This applies to grab drag interaction in general, so I moved it to scenery-phet.

Right now the running theory is that when GFL was published (our first mobile a11y grab drag interaction), iOS wouldn't move focus around, but instead just the virtual cursor. This has since changed with iOS 14.

@terracoda does not get the visual hint in the published version of GFL. We think that this was published prior to iOS14, so it doesn't really support the "we now get focus events" thought process.

We decided today that we are not actually going to focus on this for friction. We aren't supporting mobile a11y for this time because of its timeline. Marking deferred again.