search

phetsims / scenery-phet

Reusable components based on Scenery that are specific to PhET simulations.
MIT License
8 stars 6 forks source link

Triangle thumb node for slider #748

Open marlitas opened 2 years ago

marlitas commented 2 years ago

While researching a bug on the 3D water cups slider I discovered that Blackbody spectrum also has a triangular thumb node for their slider:

Screen Shot 2022-06-02 at 3 28 14 PM

Our triangular thumb node looks like this:

Screen Shot 2022-06-02 at 3 31 24 PM

Should a triangular thumb node for sliders be implemented into scenery-phet to avoid code duplication?

samreid commented 2 years ago

Yes, it seems at least some code would ideally be shared between those sims.

marlitas commented 2 years ago

After doing more research I found that Proportion Playground also uses a similar Triangle Node.

Screen Shot 2022-06-22 at 10 36 03 AM

Will be using the Perennial script: copy-history-to-different-repo.js to transfer TriangleNode.js into Scenery-Phet.

marlitas commented 2 years ago

TriangleNode has been implement into both proportionPlayground and Blackbody-spectrum. Implementing into proportion playground was not as straightforward and required the use of magic numbers to match original. I was not able to understand the local coordinate system on my own and would like review from @jonathanolson as responsible dev to properly implement TriangleNode into proportionPlayground in a manner that functions more seamlessly with existing code.

pixelzoom commented 1 year ago

Reviewing scenery-phet issues for Q4 2022 planning...

Currently assigned to @jonathanolson for review. @kathy-phet please prioritize this review.

pixelzoom commented 12 months ago

@kathy-phet @jonathanolson Noting that this has been ready for review for 9+ months.

pixelzoom commented 2 months ago

@kathy-phet @jonathanolson Noting that this has been ready for review for 18+ months.