search

phetsims / scenery-phet

Reusable components based on Scenery that are specific to PhET simulations.
MIT License
8 stars 6 forks source link

NumberControl's layoutFunctions should be resizable #778

Open jonathanolson opened 1 year ago

jonathanolson commented 1 year ago

Currently layout 4 is resizable (I needed that for a sim) but the others are not. They should support dynamic content.

jonathanolson commented 1 year ago

Came upon this in MSS, we'd really want it to respect a preferred size, so it can expand to match.

jonathanolson commented 1 year ago

Implemented above. @marlitas can you review?

zepumph commented 1 year ago

@samreid and I can confirm that there is an infinite from these commits causing https://github.com/phetsims/scenery-phet/issues/809. When we checkout https://github.com/phetsims/scenery-phet/commit/8bebb63020e50091a59603fd2a6298363e1c16b6 then we cannot reproduce the infinite loop in the scenery-phet demo. I would recommend putting this back to @jonathanolson with a high priority before review.

marlitas commented 7 months ago

Sorry for the delay getting here... I'm going to go ahead and unassign myself since it looks like it needs to be sent back to @jonathanolson before it's ready.

jonathanolson commented 3 months ago

Looks like the infinite loop isn't happening. Perhaps I can review it with @jessegreenberg this iteration.