MeasuringTapeNode should not reset Properties that it did not create.

[pixelzoom]

MeasuringTapeNode should not be resetting basePositionProperty and tipPositionProperty if it did not create them -- ie, if they were provided via options.

This is causing problems in solar-system-common, where we have a measuring tape model element that is responsible for creating and resetting these Properties. (Until this is fixed, we'll refrain from calling MeasuringTapeNode reset.)

Changing this will require testing reset behavior of all sims that use MeasuringTapeNode.

None of the authors of MeasuringTapeNode are available. So assignig to the responsibile dev for scenery-phet to decide how to proceed.

[jessegreenberg]

Sure, I will take a look this might be quick.

Hits for new MeasuringTapeNode:

• [x] charges-and-fields\js\charges-and-fields\view EDIT: An icon that is not reset.
  • ChargesAndFieldsToolboxPanel.js
• [x] energy-skate-park\js\common\view EDIT: Sim already explicitly resets these the position Properties it provides.
  • EnergySkateParkScreenView.js
• [x] fluid-pressure-and-flow\js\watertower\view EDIT: Sim already explicitly resets position Properties it provides. Ill remove the MeasuringTapeNode.reset() call.
  • WaterTowerScreenView.js
• [x] gravity-and-orbits\js\common\view EDIT: Sim already explicitly resets these.
  • GravityAndOrbitsSceneView.ts
• [x] joist\js EDIT: Doesn't use custom position Properties, but I don't know how to test this.
  • Helper.ts
• [x] projectile-motion\js\common\view EDIT: Sim already explicitly resets the Properties.
  • ProjectileMotionScreenView.ts
• [x] scenery-phet\js\demo\components EDIT: no reset in demo
  • demoMeasuringTapeNode.ts
• [x] solar-system-common\js\view EDIT: Sim is explicitly resetting these Properties.
  • SolarSystemCommonScreenView.ts
• [x] wave-interference\js\waves\view EDIT: Sim explicitly resets Properties already for full reset, but needed to replace a MeasuringTapeNode.reset() call on drag end.
  • WavesScreenView.ts
• [x] xray-diffraction\js\xray-diffraction\view EDIT: Required a new reset call for the tipPositionProperty
  • XrayDiffractionScreenView.js

extends MeasuringTapeNode:

• [x] charges-and-fields\js\charges-and-fields\view EDIT: Model explicitly resets these Properties.
  • ChargesAndFieldsMeasuringTapeNode.js

[jessegreenberg]

https://github.com/phetsims/scenery-phet/commit/6e4cd6049f9592a917dbbaa4cb2d6f78a9735825 makes this change, adding the blocks-publication label until this is tested.

[jessegreenberg]

OK, I tested and updated usages noted above and added a note for each one. @pixelzoom can you please review and any other testing you would like to see?

[pixelzoom]

Looks really great. Thanks @jessegreenberg!