samreid
commented
6 months ago I've been testing with these query parameters: http://localhost/collision-lab/collision-lab_en.html?brand=phet&ea&debugger&screens=1&listenerOrder=reverse&fuzz
This patch uncouples the DerivedProperty instances and seems to correct the fuzzing failure by avoiding the inconsistent intermediate state. I would like to request a review before committing.
```diff
Subject: [PATCH] Convert isLauncherCustom to mysteryOrCustom, see https://github.com/phetsims/projectile-data-lab/issues/93
---
Index: js/keypad/NumberAccumulator.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/keypad/NumberAccumulator.ts b/js/keypad/NumberAccumulator.ts
--- a/js/keypad/NumberAccumulator.ts (revision 8f6d0b45f5f8992e9298519098f667b5f1e34251)
+++ b/js/keypad/NumberAccumulator.ts (date 1705677060194)
@@ -80,8 +80,11 @@
this.valueProperty = new DerivedProperty(
// this.accumulatedKeysProperty is used by this.stringToInteger
- [ this.stringProperty, this.accumulatedKeysProperty ],
- ( stringValue, accumulatedKeys ) => this.stringToInteger( stringValue ), {
+ [ this.accumulatedKeysProperty ],
+ accumulatedKeys => {
+ const stringValue = this.keysToString( accumulatedKeys );
+ return this.stringToInteger( stringValue );
+ }, {
tandem: options.tandem.createTandem( 'valueProperty' ),
phetioValueType: NullableIO( NumberIO )
} );
```
@jbphet and @pixelzoom are listed as authors on NumberAccumulator, can one of you please volunteer to review? Feel free to commit if it is good.
pixelzoom
jbphet
From CT:
Oh, it’s an example of https://github.com/phetsims/axon/issues/303 where we get a callback when the accumulated keys and string are out of sync, when the listener order is reversed.