search

phetsims / scenery-phet

Reusable components based on Scenery that are specific to PhET simulations.
http://scenerystack.org/
MIT License
9 stars 6 forks source link

In the StopwatchNode, allow adding additional buttons and/or removing the play/pause/rewind buttons #843

Closed samreid closed 8 months ago

samreid commented 9 months ago

As part of the design for https://github.com/phetsims/projectile-data-lab/issues/94#issuecomment-1936158822, we agreed we wanted to customize the StopwatchNode by adding a sim-specific button and removing the rewind/play/pause buttons. I described this would complicate the API and implementation of StopwatchNode, but we agreed this was important and worth the effort.

samreid commented 9 months ago

@matthew-blackman and I implemented it above and will request review as part of https://github.com/phetsims/projectile-data-lab/issues/32

pixelzoom commented 8 months ago

In code review https://github.com/phetsims/projectile-data-lab/issues/32 ...

My first thought was that I would not use StopwatchNode here, since it's significantly different from the standard StopwatchNode. But @samreid and @matthew-blackman explained that they wanted to leverage everything else that comes with StopwatchNode. That said, I hate to see more features added to StopwatchNode, but I don't see anything wrong with https://github.com/phetsims/scenery-phet/commit/b491faff4bed411f7a1576961e47245f593f96cb. I did add links to this issue in https://github.com/phetsims/scenery-phet/commit/12c83d2e3eebd0fbd4f35e5064d27f4790ca572f.

samreid commented 8 months ago

Thanks, let's close this issue. We have more stopwatch work to do in https://github.com/phetsims/projectile-data-lab/issues/180 and will continue there.