search

phetsims / scenery-phet

Reusable components based on Scenery that are specific to PhET simulations.
http://scenerystack.org/
MIT License
9 stars 6 forks source link

EraserButton: add default for `accessibleName`. #879

Closed pixelzoom closed 2 weeks ago

pixelzoom commented 1 month ago

Related to https://github.com/phetsims/models-of-the-hydrogen-atom/issues/67 and https://github.com/phetsims/sun/issues/901 ...

EraseButton should have a default for accessibleName, rather than every sim adding the same value. In MOTHA https://github.com/phetsims/models-of-the-hydrogen-atom/issues/67, we identifed 'Erase' as an appropriate default. This string should be added to scenery-phet-strings_en.json. We did not identfy a default for helpText, since it is liable to be specific to each sim (what is being erased, etc.)

jessegreenberg commented 2 weeks ago

A default was added to EraserButton. Anything else for this issue @pixelzoom?

pixelzoom commented 2 weeks ago

👍🏻 Closing.