phetsims / scenery

Scenery is an HTML5 scene graph.
MIT License
54 stars 12 forks source link

If console and devtools are open, sim components can freeze #1030

Open ghost opened 4 years ago

ghost commented 4 years ago

Test Device

MacBook Air

Operating System

macOS 10.14.6

Browser

Chrome 78.0.3904.87

Problem Description

For https://github.com/phetsims/QA/issues/455.

I was messing around in the "Data: JSON" wrapper and I noticed that I wasn't able to move the robot or the mass. I had devtools open and I was using the "device mode" feature. The bug persists if you close devtools.

I'm not sure how to reproduce this issue in the standalone PhET-iO sim, and I'm not sure if it happens in other wrappers.

Visuals

issue2

Screen Shot 2019-11-11 at 3 37 29 PM

zepumph commented 4 years ago

Thanks for the bug report.

I'm not sure how to reproduce this issue in the standalone PhET-iO sim

Technically, the data json page is the "standalone" sim, in that it isn't embedded in another wrapper. That link just adds a query parameter to print events to the console. This is only to say that it is strange that this occurs here but not in the standalone version. The Data: colorized is quite similar to the json page. Can you reproduce this there?

zepumph commented 4 years ago

@lmulhall-phet, today @jessegreenberg and I were not able to reproduce this issue on his mac os. We loaded the data:json page and successfully dragged the sliders in a variety of device modes, all with dev tools open. Please reassign me if you find a way to reproduce. Thanks!

zepumph commented 4 years ago

@lmulhall-phet it has a been over a month, and we are moving towards publication, have you had any luck with this?

ghost commented 4 years ago

@zepumph, I haven’t seen this again. I’m guessing it was a fluke. Feel free to press on.

zepumph commented 4 years ago

Thanks! I'm going to close this.

ghost commented 4 years ago

For https://github.com/phetsims/QA/issues/465. I believe I found another instance of this issue, but not in the same sim:

issue

  1. I'm not able to move either the blue dot or the orange dot along the number line.
  2. The blue dot and the orange dot are on the same number.
  3. Note how, in this gif, the cursor does not change to a glove, whereas in the first gif it does.

Here's a screenshot of the whole screen:

Screen Shot 2020-01-08 at 4 28 43 PM

Pretty much the exact same setup as in the original issue with the exception of query parameters. As with the original issue, there doesn't seem to be a surefire way to trigger this; it seems random.

@zepumph, @jbphet, since we're seeing the same issue in two different sims, should we move this issue to a common code repo? If so, which one?

zepumph commented 4 years ago

I would think that perhaps scenery since it doesn't look like that knob in number line is sun/scenery-phet, and the puller is a custom Node too.

jbphet commented 4 years ago

I agree that scenery would be the appropriate repo, but unless there is a clear and repeatable way to recreate the situation, it's unlikely that much will be done on it. @lmulhall-phet - if you have the time, finding a way to repeat this would greatly increase the chances of it being addressed.

ghost commented 4 years ago

finding a way to repeat this would greatly increase the chances of it being addressed.

I will of course try, but this will be a backburner task due to the strange circumstances in which the bug occurs. Moving to scenery.

liammulh commented 2 years ago

I'm un-assigning myself since I no longer work on QA.