search

phetsims / scenery

Scenery is an HTML5 scene graph.
MIT License
54 stars 12 forks source link

Sim can crash when taking screenshots #1424

Open KatieWoe opened 2 years ago

KatieWoe commented 2 years ago

For https://github.com/phetsims/qa/issues/804 and https://github.com/phetsims/qa/issues/805. Seen on iPadOS 15.5. It didn't seem to happen on the published version of the sim. I also didn't see it on Win 11 Chrome

When taking screenshots from the phet menu, it would take a noticeably long time. This was especially the case if the function machine had three slots. If you try to drag objects while the sim is thinking it will sometimes freeze completely.

jonathanolson commented 2 years ago

It looks like my patch above has fixed this.

pixelzoom commented 2 years ago

@KatieWoe can you please verify?

You can use master and/or 1.3.0-dev.1 for testing.

Please assign back to me after verifying.

KatieWoe commented 2 years ago

Tested on iPadOS 15 Safari, Win 11 Chrome, and MacOS 12 Safari and everything looked ok from what I saw.

pixelzoom commented 2 years ago

Discussed with @KatieWoe and @jonathanolson, and decided to patch this into the 1.2 release for function-builder and function-builder-basics. (The alternative was publishing with this as a known problem, and doing a batch MR to address all sims that have this problem. But we're not sure when that might happen.)

So I patched scenery branches function-builder-1.2 and function-builder-basics-1.2 by cherry-picking these shas:

pixelzoom commented 2 years ago

The next step is to identify which published sims have this problem, and do a batch MR. That doesn't involve me, so assigning to @kathy-phet to prioritize, @jonathanolson to identify affected sims and handle the MR.