Open samreid opened 1 year ago
I would treat this more as an experiement than an implementation. The goal would be to understand the ramifications of this swap. How many places do we NEED to add a sim specific opt in. If it is more than the opt-out benefits, then perhaps we would want to keep this as is. I'm not too sure.
While I love the idea of opting in to visibleProperty
, I'm afraid that this is now going to be impossible. We have no idea what visibleProperty
elements are being used by clients, and no way to address this in an acceptable manner via a migration rule.
We can safely make this change in master using the API files as a safety net. Once we change it in Node and Sun, we can regenerate API files and see how much work is there.
Not sure if this should be here or in the other discussion ... so pasting here too. @pixelzoom @arouinfar @zepumph @matthew-blackman , @samreid - Just a question about this. If I'm understanding, you won't be able to hide or disable one of the radio buttons when there are 2. One question here ... sometimes these radiobuttons serve as a bit of a legend so you want to keep it visible, but you want the student to stay on one of the 2 specific radio buttons for a while. It sounds like uninstrumenting will mean the instructional designer won't be able to do this? Keep the 2 radio buttons, but disable the one they don't want students to select (or they don't want students to select at the moment).
If the above is accurate description, I would vote for just leaving it instrumented and keep the flexibility here.
Tagging for https://github.com/phetsims/phet-io/issues/1914
While triaging issues for POSE I noticed that the majority vote here seems to be to leave as-is. I also noticed that this issues was connected to https://github.com/phetsims/phet-io/issues/1914 which is now closed. @samreid can we close this issue?
Though this issue is old, it deserves conversation.
I noticed that the majority vote here seems to be to leave as-is.
Where are you seeing this? I think this could be one of the most important changes to prune down useless PhET-iO elements and simplify the API.
I also noticed that this issues was connected to https://github.com/phetsims/phet-io/issues/1914 which is now closed
Looks like we are using a project board for the backlog now.
Where are you seeing this?
I just read through the CM, KP, and MK comments and it sounded like all three were generally recommending to leave as-is, but perhaps I misunderstood. We can definitely keep this open if that's the case, just was flagging what appeared to be an issue that could be closed, but happy to be wrong!
From a meeting today with @pixelzoom @zepumph @arouinfar @matthew-blackman @pixelzoom. We would like to prune more visibleProperties by making the change above. Sun components should opt in. Sim-specific components should opt in.
Also discussed alongside https://github.com/phetsims/sun/issues/826