Remove redundant uses of `interruptSubtreeInput`. - Githubissues

phetsims / scenery

Scenery is an HTML5 scene graph.

MIT License

53 stars 12 forks source link

Remove redundant uses of `interruptSubtreeInput`. #1646

Closed pixelzoom closed 1 month ago

pixelzoom commented 1 month ago

In https://github.com/phetsims/scenery/issues/1645, Node was changed so that it automatically call interruptSubtreeInput when it becomes invisible.

In the sims that I'm responsible for, interruptSubtreeInput is now redundant in these cases, and can be removed (and tested):

[x] ABS StrengthSlider
[x] FEL DCPowerSupplyNode
[x] FEL FELMovableNode
[x] FEL PowerSupplyPanel
[x] FMW AmplitudeKeypadDialog
[x] FMW AmplitudeSlider
[x] FMW DiscreteHarmonicsChartNode
[x] FMW DiscreteMeasurementToolNode
[x] FMW DiscreteSumChartNode
[x] FMW ExpandedFormButton
[x] GP CollisionCounterNode
[x] GP GasPropertiesBicyclePumpNode
[x] GQ VertexManipulator
[x] GQ FocusManipulator
[x] NS DataProbeNode
[x] VA SumVectorNode

pixelzoom commented 1 month ago

I've removed all redundant uses except those in GP. That sim is currently in 1.1 RC testing, and I don't want to complicate cherry-picks by making unnecessary changes to main. I'll circle back to GP after it has been published.