phetsims / shred

A library of JavaScript code that is used in PhET simulations that depict atoms, subatomic particles, and atomic structure. This was originally created to contain the code that is shared between the "Build an Atom" and "Isotopes and Atomic Mass" simulations, thought it may be applied to additional simulations in the future.
GNU General Public License v3.0
1 stars 6 forks source link

there are some usages of console.error that should be replaced with assert #10

Closed jbphet closed 8 years ago

jbphet commented 8 years ago

I ran across a usage of console.error while reviewing the Build an Atom code, and then found that there are three instances of this in the shred code. These should be replaced with assert statements or, if it is an unrecoverable error, a throw new Error().

aadish commented 8 years ago

fixed, closing