search

phetsims / shred

A library of JavaScript code that is used in PhET simulations that depict atoms, subatomic particles, and atomic structure. This was originally created to contain the code that is shared between the "Build an Atom" and "Isotopes and Atomic Mass" simulations, thought it may be applied to additional simulations in the future.
GNU General Public License v3.0
1 stars 6 forks source link

ParticleCountDisplay should extend Panel #20

Closed samreid closed 7 years ago

samreid commented 7 years ago

Discovered in https://github.com/phetsims/scenery-phet/issues/262

and fixed in https://github.com/phetsims/shred/commit/b94833de64085dd63d99e5f8940971389e8e1369

@jbphet or @aadish can you please review?

jbphet commented 7 years ago

Change looks good, and I tested it in Build an Atom by adding and removing particles and testing the max size. All looking good. Thanks @samreid, closing.