search

phetsims / soccer-common

"Soccer Common" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 1 forks source link

webgl flag is disturbing SVG rendering of kickers #11

Closed marlitas closed 3 months ago

marlitas commented 4 months ago

In order to fix https://github.com/phetsims/center-and-variability/issues/91, we added the option renderer: 'webgl' to KickerNode in soccer-common. Now that we are wanting to use SVG artwork instead of PNG setting the renderer to webgl is removing SVG's ability to be able to expand and contract with no quality loss. After testing for the bug in FireFox with the new SVG images I was unable to reproduce the flicker.

Once all images have been converted to SVG, I would like QA to confirm that the flicker is indeed gone and we are safe to remove that flag.

marlitas commented 3 months ago

We have converted all of the kickers to svg files and are ready to test if the flashing is still occurring in firefox. @Nancy-Salpepi and/or @KatieWoe I tested in firefox and didn't see anything on my end, but would love a confirmation by QA.

I followed the reproduction steps in https://github.com/phetsims/center-and-variability/issues/91

Thanks!

Nancy-Salpepi commented 3 months ago

Looks good to me on mac + FF and Win10 + FF!

marlitas commented 3 months ago

Awesome. Thank you. FYI @amanda-phet. I'm going to go ahead and close.