search

phetsims / soccer-common

"Soccer Common" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 1 forks source link

Keyboard focus may not be on top soccer ball #16

Closed KatieWoe closed 2 weeks ago

KatieWoe commented 3 weeks ago

Test device Samsung Operating System Win 11 Browser Chrome Problem description For https://github.com/phetsims/qa/issues/1094 If you move the soccer balls around then activate keyboard nav, focus may be on a ball in the middle of a stack, rather than the top ball. Steps to reproduce

  1. Go to the last screen
  2. Kick all 7 balls
  3. With mouse, stack all the balls in one pile
  4. Activate keyboard nav and focus on the soccer balls

Visuals middlepack

Troubleshooting information:

!!!!! DO NOT EDIT !!!!! Name: ‪Mean: Share and Balance‬ URL: https://phet-dev.colorado.edu/html/mean-share-and-balance/1.1.0-dev.6/phet/mean-share-and-balance_all_phet.html Version: 1.1.0-dev.6 2024-06-11 15:27:57 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36 Language: en-US Window: 1536x695 Pixel Ratio: 1.25/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 4096 Texture: size: 8192 imageUnits: 32 (vertex: 32, combined: 64) Max viewport: 8192x8192 OES_texture_float: true Dependencies JSON: {}
marlitas commented 2 weeks ago

Okay looks like this is a bug in soccer-common because I'm seeing it in the local version of center and variability as well. I'm moving this to that repo to investigate further.

marlitas commented 2 weeks ago

This was a fun exploration where we were grabbing from any active ball instead of only top balls at one point. I got rid of that assumption and it's looking good. @KatieWoe can you confirm all looks well on local?

KatieWoe commented 2 weeks ago

Looks ok on main

marlitas commented 2 weeks ago

Great. I think we can close.