search

phetsims / sound-waves

"Sound Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 1 forks source link

Add credits #12

Closed samreid closed 11 months ago

samreid commented 1 year ago

From a TODO, we need to add credits in sound-main.ts

matthew-blackman commented 1 year ago

Credits are in. @samreid can you review if this is sufficient for acknowledging previous work and external partners?

Nancy-Salpepi commented 1 year ago

Thanks for updating the QA credits @matthew-blackman. Was Marla supposed to be added? I don't know the scope of her involvement.

Also, from https://github.com/phetsims/sound-waves/issues/12#issuecomment-1684368767, @samreid do the credits look good to you?

samreid commented 1 year ago

Comparing to other credits dialogs, this one appears to be a sentence fragment. This sim has:

thanks: 'Jan Willems, University of Leuven, for supporting the conversion of this simulation from Java to HTML5.'

But other sims have wording like:

thanks: 'Thanks to Actual Concepts for working with the PhET development team to convert this simulation to HTML5.'

or

thanks: 'We gratefully acknowledge the support of ECO Canada for helping to fund this sim.'

or 

  thanks: 'We gratefully acknowledge support from STROBE NSF Science & Technology Center Grant DMR-1548924.   Any opinions, findings, and conclusions or recommendations expressed in this material are those of the author(s) and do not necessarily reflect the views of the National Science Foundation.

etc.

Number play also just has a name list though.

matthew-blackman commented 11 months ago

Credits are up to date on both the sim and sim page. Closing.