Review sim strings for dynamic length and localization

phetsims / sound-waves

"Sound Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

0 stars 1 forks source link

Review sim strings for dynamic length and localization #23

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

The sim is in a good place as far as features. We'd like to take a look at dynamic strings and localization before moving into dev testing.

samreid commented 1 year ago

Please be aware of constraints in the stopwatch node described in https://github.com/phetsims/scenery-phet/issues/814

marlitas commented 1 year ago

The patternString implementation has been committed above. Over to you for review @matthew-blackman!

matthew-blackman commented 1 year ago

Pattern string for frequency slider is looking great. Nice work @marlitas! The sim strings are looking good for the scope of this "quick and dirty" release. It should be noted that when revisitng this sim, we want to spend some time working on dynamic strings for the RulerNode and StopwatchNode. Closing.