Closed Nancy-Salpepi closed 1 year ago
Also, the location of the frequency readout makes it look like it is the value of the middle tick mark. The java version had the value off-center with more space between it and the scale.
Great suggestions @Nancy-Salpepi - will implement and tag you when ready for review
Font looks much better! I can actually read it! haha
Reopening to confirm during next dev test.
Looks much better to me. I did notice that the "ATM" on the pressure gauge on the Air Pressure screen was a bit small. Is that worth a look?
I expanded the options of GaugeNode to allow a custom font size for the label, and also increased the font of the numerical labels on the pressure gauge. @KatieWoe can you spot-check on main?
@samreid might be good to get a review here as well since GaugeNode is a scenery component. Let me know if you have any questions!
Thanks, looks good and I have a few recommendations for next steps:
labelTextOptions: TextOptions
. We'll still need to combineOptions
to get the tandem. Let's leave the existing logic for maxWidth. See NumberControl for an example of the nested options pattern: https://github.com/phetsims/scenery-phet/blob/234fc50e13fee7c04ee9e79bc62f4539475e6a24/js/NumberControl.ts#L164Looks ok to me on main
Thanks for the feedback @samreid! I gave this a try in the above commits.
The text in the GaugeNode is ready for a spot check on main.
Looks good on main
Font size looks good to me in rc.2. Closing.
Test device MacBook Air M1 chip
Operating System 13.5
Browser Safari 16.6
Problem description For https://github.com/phetsims/qa/issues/972, the font size is unusually small in this sim. I know this is meant to be a quick release, but I wanted to mention it.
Here is a comparison with Gravity and Orbits: