Panels become misaligned with stringTest=double

[Nancy-Salpepi]

Test device Dell

Operating System Win10

Browser Chrome

Problem description For https://github.com/phetsims/qa/issues/972, with ?stringTest=double, the panels on the Air Pressure screen become misaligned.

Visuals

Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Sound Waves‬:‪Sound Waves‬ URL: https://phet-dev.colorado.edu/html/sound-waves/1.0.0-dev.5/phet/sound-waves_all_phet.html?stringTest=double Version: 1.0.0-dev.5 2023-08-21 17:16:24 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36 Language: en-US Window: 1433x729 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}

[matthew-blackman]

The panel horizontal alignment has been fixed and is updating nicely for me. Looking at the vertical spacing, things are looking good enough to me until the strings get really long. The cost to implement a dynamic approach for vertical spacing is nontrivial and may be outside the scope of this release.

@samreid / @marlitas would like to hear your thoughts on this.

[KatieWoe]

The text boxes now stay in line. However, the text looks quite small when doubled. The Audio Controls box looks particularly odd.

[marlitas]

Perhaps we can increase the max width on some of the text in these panels. But I agree. Full dynamic layout is not expected to be supported in this release.

[matthew-blackman]

This has been addressed in the commits on https://github.com/phetsims/sound-waves/issues/37. Please confirm.

[KatieWoe]

I'm still seeing the oddly sized text with long strings on the last screen. With dynamic strings and without.

[Nancy-Salpepi]

this looks good to me on main:

[matthew-blackman]

This issue has been fixed, confirmed in RC1. Closing.