search

phetsims / sound-waves

"Sound Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 1 forks source link

Extreme low frequencies are problematic #34

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

In dev testing, it was noted that extreme low frequencies (under 50 Hz) lead to issues such as https://github.com/phetsims/sound-waves/issues/30 and https://github.com/phetsims/sound-waves/issues/33, as well as visual problems with the frame-by-frame animation of the vibrating speaker.

These extreme low frequencies do not add to the pedagogical value of the sim, and I recommend capping the minimum frequency at 100 Hz. This will still allow users to study the relationship between frequency and wavelength, without breaking the limitations of the speaker animation system and Amplitude / Pulse controls.

matthew-blackman commented 1 year ago

The speaker frequency range has been update to 100Hz - 1000Hz and is working nicely. Closing this issue and will track remaining work in https://github.com/phetsims/sound-waves/issues/30 and https://github.com/phetsims/sound-waves/issues/33.

matthew-blackman commented 1 year ago

Reopening this issue for spot-check during RC 1.0

KatieWoe commented 1 year ago

This change has been implemented and looks alright in rc.1