phetsims / sound-waves

"Sound Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 1 forks source link

Waves look odd when the wall is moved while paused #36

Closed Nancy-Salpepi closed 1 year ago

Nancy-Salpepi commented 1 year ago

Test device MacBook Air (m1 chip)

Operating System 13.5

Browser safari 16.5

Problem description For https://github.com/phetsims/qa/issues/974, this might be outside the scope of this release, but it looks really odd to me that the wave doesn't disappear/update when the wall is moved during pause.

Steps to reproduce

  1. Go to the Reflection Screen and pause the sim after waves have reached the wall
  2. Move the Wall Angle slider all the way to the right
  3. Press play and then pause again
  4. Move the Wall Position slider all the way to the right

Visuals

Screenshot 2023-08-30 at 1 37 19 PM Screenshot 2023-08-30 at 1 37 32 PM
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Sound Waves‬ URL: https://phet-dev.colorado.edu/html/sound-waves/1.0.0-rc.2/phet/sound-waves_all_phet.html Version: 1.0.0-rc.2 2023-08-28 14:05:18 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.6 Safari/605.1.15 Language: en-US Window: 1346x717 Pixel Ratio: 2/1 WebGL: WebGL 1.0 GLSL: WebGL GLSL ES 1.0 (1.0) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 30 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
Nancy-Salpepi commented 1 year ago

What is really interesting is....if I take a screenshot from the PhET menu, it shows the "updated" wave. Here is what the screen looks like:

Screenshot 2023-09-01 at 9 51 08 AM

And here is the screenshot taken from the PhET menu:

Screenshot 2023-09-01 at 9 51 25 AM

It also "updates" in the other direction. Here is the screen:

Screenshot 2023-09-01 at 9 56 26 AM

And here is the screenshot: Sound Waves screenshot (7)

Nancy-Salpepi commented 1 year ago

I see something similar with the screenshots when moving the speaker while paused on the Two Sources Screen. Steps:

  1. On the Two Sources screen wait a couple of seconds and then press pause
  2. Move the speaker to the top of the play area
  3. Take a screenshot

What it looks like in the sim:

Screenshot 2023-09-01 at 1 12 04 PM

What the screenshot looks like: Sound Waves screenshot (8)

matthew-blackman commented 1 year ago

This has been fixed on main and ready for spot-check! Both the 2-source and the reflection screens show updated waves when changing properties while the sim is paused.

KatieWoe commented 1 year ago

Looks ok to me on main.

Nancy-Salpepi commented 1 year ago

This looks great now!

Nancy-Salpepi commented 1 year ago

Looks good in rc.2! Closing.