search

phetsims / sound-waves

"Sound Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 1 forks source link

Preferences should have localization #39

Closed matthew-blackman closed 1 year ago

matthew-blackman commented 1 year ago

The sim will support translation, so we should have a localization menu in the preferences.

matthew-blackman commented 1 year ago

@marlitas and I checked in on this and it looks like the sim has a localization tab when the query parameter &locales=* is added. This looks correct to us.

QA can you confirm that the localization tab appears when it should?

Nancy-Salpepi commented 1 year ago

@matthew-blackman and @marlitas the localization tab appears when the query parameter is added to the sim on main. It doesn't appear when added to the rc.2 version. I think that is correct behavior, but thought I would double check with you before closing.

matthew-blackman commented 1 year ago

@marlitas and I confirmed this - thanks @Nancy-Salpepi! We should be good to close.