search

phetsims / sound-waves

"Sound Waves" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 1 forks source link

Repo name does not match legacy project name #44

Closed arouinfar closed 2 months ago

arouinfar commented 7 months ago

Similar to https://github.com/phetsims/faradays-electromagnetic-lab/issues/91.

The Java version was called "Sound" with a project name of sound. The HTML5 version was renamed "Sound Waves" and its repo name is sound-waves. Both versions are currently visible on the website, which shouldn't happen for ports.

Screenshot 2024-04-01 at 9 11 40 AM

@mattpen can you please add a mapping of sound to sound-waves to the website?

mattpen commented 7 months ago

This will be addressed in Website Maintenance in the next iteration, and should be deployed by 4/25.

mattpen commented 7 months ago

I'm going to try this first on ox-dev, as this would be the first java-port community contribution sim, and I'm not sure how the sim pages will behave.

mattpen commented 7 months ago

It looks like this is being published as a Community Sim (and does not have the java Run Options page). @arouinfar - is this intended, or would you rather show the page that can run the java or the community sim (like we do for cheerpj sims with a prototype)?

Preview: https://ox-dev.colorado.edu/en/simulations/sound-waves https://ox-dev.colorado.edu/en/simulations/sound (points to sound-waves now)

arouinfar commented 7 months ago

Good question @mattpen. I wouldn't show the Java run options on Community sims. The cheerpj/java options are nice for Prototypes, which are often incomplete. However, I don't think we would publish an incomplete sim as a Community contribution.

mattpen commented 7 months ago

Sounds great, this is staged for the Maintenance Y release (will be deployed by 4/25)

mattpen commented 2 months ago

This was deployed some time ago. Closing.