Open samreid opened 2 years ago
I don't know much of the back story here, and I read through the linked issue above, and I'm still feeling in the dark. You can test the sim using locale=nl
to see if the translation is complete and functional. Since the translation file only contains values and no history or user ID, I'm not sure whether it will work with the build server to produce the expected built versions when the sim is published (I'm assuming that it isn't already published). I suspect it will, but we've never tested this particular case. One problem I can say for certain is that without user IDs in the translation file, there will be no translation credit on the website. If that's important, it should probably be addressed.
Based on the considerations above, it sounds appropriate to resumbit the translations through rosetta once the sim is published, to avoid corner cases and so that our artifacts in babel are consistent. So I will recommend putting this issue on hold until published.
@matthew-blackman volunteered to add these strings using Rosetta after publication. @jbphet will @matthew-blackman need credentials or a rosetta account?
[W]ill @matthew-blackman need credentials or a rosetta account?
If he has a login set up for the phet website he should be good to go. I'll assign this to @mattpen to verify that @matthew-blackman has such an account and is set up as a PhET team member.
The downside to @matthew-blackman submitting it via Rosetta is that he will be credited as a translator for this locale and sim on the website and his user ID will be stored in the babel file as the contributor. If possible, it would probably be better to talk the translator into re-submitting via Rosetta.
@matthew-blackman - are you able to logon here: https://phet.colorado.edu/en/sign-in? If so, do you see an "Administration" item in the user menu?
If so, you should be good to go. If you can sign in but don't see Administration, please send me the email address you use. If you can't sign in, you need to register first: https://phet.colorado.edu/en/register
Everything looks good for Admin privileges, thanks @mattpen!
With regard to @jbphet's concerns:
The downside to @matthew-blackman submitting it via Rosetta is that he will be credited as a translator for this locale and sim on the website and his user ID will be stored in the babel file as the contributor. If possible, it would probably be better to talk the translator into re-submitting via Rosetta.
It sounds like we may want to reach out to the contributors from the Netherlands to see if they would like to enter in the translations and be tracked in the system for any future updates on the sim. We already have the sound-strings_nl.json
file fully filled in, so it would just boil down to data entry.
Thoughts @jbphet @kathy-phet?
My thoughts are: If the translator is willing to do the data entry that's by far the best option, and we should make a bit of an effort to sell them on it by letting them know that they will be credited on the website. If Matt B does it and has the credit, it doesn't seem horrible, so we could live with that if we have to. It is possible, but not trivial, for @mattpen and I to adjust the website and babel file after @matthew-blackman submits it so that someone else is credited, but doesn't seem worth the effort to me.
In https://github.com/phetsims/sound/issues/3, we received the nl translation for this sim. https://github.com/phetsims/sound/blob/eb69a225ca9131538d4695288252930487bf6d1d/sound-strings_nl.json
Can it be moved to babel? Do we need to do any more steps to make sure it will work correctly?