search

phetsims / sugar-and-salt-solutions

"Sugar And Salt Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 1 forks source link

Properties should have `Property` suffix #10

Closed pixelzoom closed 6 years ago

pixelzoom commented 9 years ago

Examples of anti pattern:

SugarAndSaltSharedProperties: sizeScale: new Property( 1.0 ) Dispenser: thisDispenser.enabled = new Property( false ); Dispenser: thisDispenser.angle = new Property( angle ); Dispenser: thisDispenser.center = new Property( new Vector2( x, y ) ); SugarAndSaltSolutionMode: thisModel.dispenserType = new Property( DispenserType.SALT );

veillette commented 6 years ago

Closing this issue since it is a duplicate of #8