chem symbols should not be translatable

phetsims / sugar-and-salt-solutions

"Sugar And Salt Solutions" is an educational simulation in HTML5, by PhET Interactive Simulations.

GNU General Public License v3.0

1 stars 1 forks source link

chem symbols should not be translatable #19

Closed pixelzoom closed 6 years ago

pixelzoom commented 9 years ago

See https://github.com/phetsims/molecules-and-light/issues/124.

jhd-dev commented 6 years ago

881098ba817b5b6a0112a10fb021f508bad896f3 We changed the calcium symbol's string to be hard-coded into the sim, rather than in the list of translatable strings.

jhd-dev commented 6 years ago

We moved the strings involving chemicals symbols to MicroSoluteKitList.js, from sugar-and-salt-solutions_en.json. I believe the all work for this issue is done. Assigning to @pixelzoom for review.

pixelzoom commented 6 years ago

Looks good. I added a comment that refers to this issue, so that readers aren't wondering why these string are not translated.

Closing.