search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

improve Dialog #433

Open pixelzoom opened 8 years ago

pixelzoom commented 8 years ago

In https://github.com/phetsims/joist/issues/357#issuecomment-248452092, @ariel-phet said:

@samreid and @pixelzoom please discuss and collaborate on improving dialog. We are adding dialogs in several sims with increased functionality so now would be a good time to improve the implementation. How about come up with a plan and lets discuss a developer meeting, and we can prioritize further there.

In https://github.com/phetsims/joist/issues/357#issuecomment-248759332, I said:

@samreid and I discussed the general status of Dialog today via Skype. But we have no plan yet for how to move forward. The first order of business would likely be to triage related issues, evaluate the current implementation, then decide whether to revised the currently implementation or start over.

CM edit, so I don't have to search comments for link to design doc: https://docs.google.com/document/d/19h0U5iqeChirUvVRaudUbmSP_J3yMn7FgnILWrUq9-c/edit

samreid commented 6 years ago

Also noted: @jessegreenberg has been working on a Pane framework for showing screenview dialogs vs sim dialogs.

pixelzoom commented 6 years ago

Re non-modal dialogs... Dialog currently has no support for non-modal dialogs, and no non-modal dialogs have been needed by PhET sims. Re-design of Dialog should definitely consider non-modal dialogs. See https://github.com/phetsims/joist/issues/293 for historical information.

pixelzoom commented 5 years ago

Dialog has been moved to sun, so I'm going to move this issue from joist to sun, using GitHub's new "Transfer issue" feature.

pixelzoom commented 5 years ago

Reassigning to @ariel-phet for prioritization and assignment.

ariel-phet commented 3 years ago

This work is just not currently a priority for the project. Marking deferred