search

phetsims / sun

User-interface components for PhET simulations, built on top of Scenery.
MIT License
4 stars 12 forks source link

Add voicing to ToggleSwitch #731

Closed zepumph closed 2 years ago

zepumph commented 2 years ago

This issue is part of the general clean up of the voicing feature which @jessegreenberg is working on, but I need to do this eagerly because I ran into an inner class called VoicingToggleSwitch in PreferencesToggleSwitch that was buggy in how late it initializes Voicing. Adding the mixin to common code is the only (and best) way to fix this.

I hit this while working on https://github.com/phetsims/scenery/issues/1283 (more specifically https://github.com/phetsims/scenery/issues/1283#issuecomment-992800551)

zepumph commented 2 years ago

@jessegreenberg can you please review? Does this make sense to you and seem complete?

jessegreenberg commented 2 years ago

Makes sense, thank you! I think this is all we need for Voicing in ToggleSwitch. I thought for a moment about whether we should implement the object/context response somehow in ToggleSwitch but decided it was not worth it and we have not put Interactive Description context responses in ToggleSwitch either.

Does that work for you/anything else for this?